Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto_readahead_size default true #12080

Conversation

akankshamahajan15
Copy link
Contributor

Summary: Make auto_readahead_size option default true

Test Plan: benchmarks and exisiting tests

Reviewers:

Subscribers:

Tasks:

Tags:

@akankshamahajan15 akankshamahajan15 force-pushed the default_auto_readahead_size branch 3 times, most recently from d88bb9c to dfc6f51 Compare November 20, 2023 19:48
db/db_iter.cc Outdated Show resolved Hide resolved
file/prefetch_test.cc Show resolved Hide resolved
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akankshamahajan15 akankshamahajan15 force-pushed the default_auto_readahead_size branch 2 times, most recently from d620813 to 39df645 Compare December 14, 2023 02:30
Summary: Make auto_readahead_size option default true

Test Plan: benchmarks and exisiting tests

Reviewers:

Subscribers:

Tasks:

Tags:
@akankshamahajan15 akankshamahajan15 force-pushed the default_auto_readahead_size branch from 39df645 to 1d121b1 Compare December 14, 2023 03:33
@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@akankshamahajan15 merged this pull request in e7c6259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants